[#164968781] Fix scroll on Android patching ReactScrollView #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpersico
force-pushed
the
164968781-patch-reactscrollview
branch
from
03328a4
to
7fdd6a8
Compare
fpersico
force-pushed
the
164968781-patch-reactscrollview
branch
from
7fdd6a8
to
18138c8
Compare
Affected stories
Generated by 🚫 dangerJS |
|
Thanks @fpersico - @Undermaken give it a look |
cloudify
approved these changes
Apr 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #919 +/- ##
=======================================
Coverage 44.62% 44.62%
=======================================
Files 197 197
Lines 4166 4166
Branches 825 796 -29
=======================================
Hits 1859 1859
Misses 2302 2302
Partials 5 5 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #919 +/- ##
=======================================
Coverage 44.62% 44.62%
=======================================
Files 197 197
Lines 4166 4166
Branches 825 796 -29
=======================================
Hits 1859 1859
Misses 2302 2302
Partials 5 5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix the bug reported in the story and also here facebook/react-native#22938 applying the patch suggested here facebook/react-native#22925 (comment).