Skip to content

fix: [IEL-685] Added logic to poll the app's status in the FCI flow#8260

Merged
Ladirico merged 5 commits into
masterfrom
IEL-685
Jul 13, 2026
Merged

fix: [IEL-685] Added logic to poll the app's status in the FCI flow#8260
Ladirico merged 5 commits into
masterfrom
IEL-685

Conversation

@Ladirico

@Ladirico Ladirico commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Short description

In this PR, logic for polling the app's status has been added to the FCI flow.
This logic was added because there are cases where, at the end of the FCI flow, the PIN or biometric must be entered. On iOS, when biometrics are entered, the app enters the “inactive” state, and after biometrics are entered (when the identificationSuccess action is dispatched), the final call in the signature flow is made.
There are cases where the OS stops the call and then restarts it when the app is in the “inactive” state.
Polling is used to avoid these cases and to make the /signatures call only when the app returns to the “active” state, polling the state for up to 20 seconds. If the polling is not successful, we proceed anyway and accept the risk of the call being truncated. However, we expect these cases to be very rare (almost nonexistent).

List of changes proposed in this pull request

  • Add polling logic
  • Add test

Demo

Registrazione.schermo.2026-07-09.alle.10.22.53.mov

How to test

Run the application on iOS physical device (on simulators the app state not change)
Try if it works on Android devices too (on Android the state is always active)

@Ladirico Ladirico requested a review from soixdev91 July 9, 2026 08:36
@Ladirico Ladirico self-assigned this Jul 9, 2026
@Ladirico Ladirico added the IO-Ecosystem Links IO - Ecosystem Links label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.92%. Comparing base (2b2cfad) to head (d69ee96).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
apps/main-app/ts/features/fci/saga/index.ts 38.46% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8260   +/-   ##
=======================================
  Coverage   62.92%   62.92%           
=======================================
  Files        1963     1963           
  Lines       37239    37251   +12     
  Branches     6250     6253    +3     
=======================================
+ Hits        23431    23439    +8     
- Misses      12423    12428    +5     
+ Partials     1385     1384    -1     
Files with missing lines Coverage Δ
apps/main-app/ts/features/fci/saga/index.ts 58.75% <38.46%> (-4.49%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033ff69...d69ee96. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@soixdev91 soixdev91 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ladirico Ladirico added this pull request to the merge queue Jul 13, 2026
Merged via the queue into master with commit b4490c6 Jul 13, 2026
12 checks passed
@Ladirico Ladirico deleted the IEL-685 branch July 13, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO-Ecosystem Links IO - Ecosystem Links

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants