Conversation
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8260 +/- ##
=======================================
Coverage 62.92% 62.92%
=======================================
Files 1963 1963
Lines 37239 37251 +12
Branches 6250 6253 +3
=======================================
+ Hits 23431 23439 +8
- Misses 12423 12428 +5
+ Partials 1385 1384 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
In this PR, logic for polling the app's status has been added to the FCI flow.
This logic was added because there are cases where, at the end of the FCI flow, the PIN or biometric must be entered. On iOS, when biometrics are entered, the app enters the “inactive” state, and after biometrics are entered (when the
identificationSuccessaction is dispatched), the final call in the signature flow is made.There are cases where the OS stops the call and then restarts it when the app is in the “inactive” state.
Polling is used to avoid these cases and to make the
/signaturescall only when the app returns to the “active” state, polling the state for up to 20 seconds. If the polling is not successful, we proceed anyway and accept the risk of the call being truncated. However, we expect these cases to be very rare (almost nonexistent).List of changes proposed in this pull request
Demo
Registrazione.schermo.2026-07-09.alle.10.22.53.mov
How to test
Run the application on iOS physical device (on simulators the app state not change)
Try if it works on Android devices too (on Android the state is always active)