feat(IT-Wallet): [SIW-4617] Use guided tour for wallet add action#8248
feat(IT-Wallet): [SIW-4617] Use guided tour for wallet add action#8248riccardosacco99 wants to merge 1 commit into
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8248 +/- ##
==========================================
- Coverage 62.79% 62.78% -0.01%
==========================================
Files 1952 1954 +2
Lines 37079 37114 +35
Branches 6203 6217 +14
==========================================
+ Hits 23282 23301 +19
- Misses 12413 12419 +6
- Partials 1384 1394 +10
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
| title: string; | ||
| description: string; | ||
| cutoutStyle?: TourCutoutStyle; | ||
| cutoutPadding?: number; |
There was a problem hiding this comment.
We should add padding to TourCutoutStyle instead. What do you think?
|
I have a few concerns about this change:
This implementation makes the component more rigid and increases the cost of future changes. Could we explore alternative approaches? For example, have we considered retrieving the button's position and overlaying the cutout on top of it, rather than modifying the header component itself? |
Short description
Update the IT Wallet guided tour so the “Add document” step highlights the “+” header action itself, instead of a manually measured header region. The step is now attached to the header action through
GuidedTour, so the cutout follows the real button position and size.Copy updates for the tour steps are handled separately in #8209 (SIW-4475).
List of changes proposed in this pull request
IOHeaderFirstLevel, an app-level wrapper of the design systemHeaderFirstLevelthat supportstourGuidePropson header actions without changing the design system.useGuidedTourRegionregistration (screen-size based) fromuseItwGuidedTour.cutoutPaddingsupport toGuidedTourmeasurements so the highlighted area can cover the full tappable area of the header action.How to test
Automated:
pnpm --dir apps/main-app exec jest --coverage=false ts/features/tour/utils/__tests__/measurement.test.ts ts/components/ui/__test__/IOHeaderFirstLevel.test.tsx ts/features/wallet/screens/__tests__/WalletHomeScreen.test.tsxManual: