refactor: [IEG-2929] Replace fp-ts with vanilla ts in CGN#8246
Open
LeleDallas wants to merge 7 commits into
Open
refactor: [IEG-2929] Replace fp-ts with vanilla ts in CGN#8246LeleDallas wants to merge 7 commits into
fp-ts with vanilla ts in CGN#8246LeleDallas wants to merge 7 commits into
Conversation
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This pull request focuses on simplifying the codebase by removing unnecessary functional programming dependencies (such as
fp-ts'sOption,Either, andpipe) and replacing them with more idiomatic and straightforward TypeScript code.List of changes proposed in this pull request
fp-ts'sOption,Either, andpipewith native TypeScript constructs and simplified conditional logicfp-tsconstructs, using plain objects for responses and errors, and adjusted assertions accordinglyErrorobjects instead of wrapping them inEitheror custom types, and using a consistent approach for network and generic errors.How to test
Ensure CGN flow has no regression in all screens