chore: [IOPLT-1945] Enforce ESLint no-dynamic-delete rule as error#8244
Open
dmnplb wants to merge 12 commits into
Open
chore: [IOPLT-1945] Enforce ESLint no-dynamic-delete rule as error#8244dmnplb wants to merge 12 commits into
no-dynamic-delete rule as error#8244dmnplb wants to merge 12 commits into
Conversation
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
dmnplb
added
💀 Dead matter
dmnplb
changed the title
no-dynamic-delete rule as error + Add test coverageno-dynamic-delete rule as error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8244 +/- ##
==========================================
+ Coverage 62.90% 62.97% +0.07%
==========================================
Files 1963 1963
Lines 37246 37203 -43
Branches 6250 6237 -13
==========================================
Hits 23430 23430
+ Misses 12430 12388 -42
+ Partials 1386 1385 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
dmnplb
requested review from
a team,
ChrisMattew,
emilio-dimari,
gispada and
soixdev91
as code owners
LeleDallas
approved these changes
Jul 8, 2026
LeleDallas
left a comment
LeleDallas
left a comment
Contributor
There was a problem hiding this comment.
Overall, it looks good to me.
Since removed code is not related to my stream, could you please wait for the affected owners to review and approve it before merging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Enforce ESLint
no-dynamic-deleterule as error. Remove the unreferenced code that was left in the codebase by mistake.List of changes proposed in this pull request
deleteRelated
@pagopa/eslint-configto theeslintconfiguration #7992How to test
N/A