chore(IT Wallet): [SIW-1089] Add NFC enable state check saga #5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n' into SIW-1089-add-nfc-enabled-state-check
pagopa-github-bot
changed the title
|
🎉 All dependencies have been resolved ! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5745 +/- ##
==========================================
+ Coverage 48.42% 48.96% +0.53%
==========================================
Files 1488 1605 +117
Lines 31617 32198 +581
Branches 7669 7738 +69
==========================================
+ Hits 15311 15766 +455
- Misses 16238 16374 +136
+ Partials 68 58 -10
... and 213 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
hevelius
approved these changes
May 8, 2024
mastro993
added a commit
that referenced
this pull request
May 10, 2024
> [!WARNING] > This PR depends on #5745 ## Short description This PR adds the screen to display the instructions to enable the NFC for Android users. ## List of changes proposed in this pull request - Added `ItwIdentificationNfcInstructionsScreen` component - Added required locale keys ## How to test In order to test this PR on dev environment, make sure to add this flag to your .env: ``` # Enable CIE login flow with emulator and dev server CIE_LOGIN_WITH_DEV_SERVER_ENABLED=YES ``` #### On a simulator Go to **Profile > IT Wallet > Issuing**, clicking on CIE + PIN you should be able to see the NFC instructions screen. #### On a physical Android device Disable the NFC, then go to **Profile > IT Wallet > Issuing**, clicking on CIE + PIN you should be able to see the NFC instructions screen. ## Preview <img src="https://github.com/pagopa/io-app/assets/6160324/eb608463-8eb5-4bd1-93db-6e77302e80a5" width="250" /> --------- Co-authored-by: Jacopo Pompilii <Jacopo.pompilii@pagopa.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR depends on #5729
Short description
This PR adds the logic to check and store the device's NFC state
List of changes proposed in this pull request
isItWalletTestEnabledflag is set totrueHow to test
Test should solve correctly