Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#164896228] Message list rows predictable and fixed height #1039

Merged
merged 23 commits into from
May 21, 2019

Conversation

lmorelli986
Copy link
Contributor

@lmorelli986 lmorelli986 commented May 10, 2019

This PR aims to change message list components setting their height fixed letting list height to be predictable and the pre-calculated for optimization pourposes.

Simulator Screen Shot - iPhone X - 2019-05-10 at 14 42 43

@digitalcitizenship
Copy link

digitalcitizenship commented May 10, 2019

Affected stories

  • 🌟 #164896228: Le righe della lista messaggi devono avere un altezza fissa o prevedibile

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1039 into master will decrease coverage by 0.07%.
The diff coverage is 30.66%.

@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
- Coverage   45.24%   45.16%   -0.08%     
==========================================
  Files         211      211              
  Lines        4854     4900      +46     
  Branches      951      967      +16     
==========================================
+ Hits         2196     2213      +17     
- Misses       2651     2680      +29     
  Partials        7        7

@cloudify
Copy link
Contributor

This pull request introduces 1 alert when merging 02b637d into 468c89c - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@lmorelli986
Copy link
Contributor Author

@cloudify I got forbidden access to https://lgtm.com/projects/g/teamdigitale/io-app/rev/pr-40c248496f38c5a69464554ea1871ef2610f1223

I just removed an unncecessary dependency, was it related to the issue you told me about?

@cloudify
Copy link
Contributor

This pull request introduces 1 alert when merging 38c94ac into 468c89c - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@lmorelli986 lmorelli986 marked this pull request as ready for review May 10, 2019 12:47
@cloudify
Copy link
Contributor

This pull request introduces 1 alert when merging ebfdd26 into 468c89c - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@fpersico fpersico changed the title [#164896228] message list rows' predictable and fixed height [#164896228] Message list rows' predictable and fixed height May 20, 2019
@cloudify
Copy link
Contributor

This pull request introduces 1 alert when merging 156fb5a into b04228a - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@cloudify
Copy link
Contributor

This pull request introduces 1 alert when merging 1363890 into b04228a - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@cloudify
Copy link
Contributor

This pull request introduces 1 alert when merging b3bfa67 into c6fbdd8 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@cloudify
Copy link
Contributor

This pull request introduces 1 alert when merging 85cbb89 into c6fbdd8 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@cloudify
Copy link
Contributor

This pull request introduces 1 alert when merging 50c9c0f into c6fbdd8 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@fpersico fpersico changed the title [#164896228] Message list rows' predictable and fixed height [#164896228] Message list rows predictable and fixed height May 21, 2019
@fpersico fpersico merged commit cdb397d into master May 21, 2019
@fabriziofff fabriziofff deleted the 164896228-same-height-messages branch January 21, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants