-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#164896228] Message list rows predictable and fixed height #1039
Conversation
Affected stories
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
- Coverage 45.24% 45.16% -0.08%
==========================================
Files 211 211
Lines 4854 4900 +46
Branches 951 967 +16
==========================================
+ Hits 2196 2213 +17
- Misses 2651 2680 +29
Partials 7 7 |
This pull request introduces 1 alert when merging 02b637d into 468c89c - view on LGTM.com new alerts:
Comment posted by LGTM.com |
@cloudify I got forbidden access to https://lgtm.com/projects/g/teamdigitale/io-app/rev/pr-40c248496f38c5a69464554ea1871ef2610f1223 I just removed an unncecessary dependency, was it related to the issue you told me about? |
This pull request introduces 1 alert when merging 38c94ac into 468c89c - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 1 alert when merging ebfdd26 into 468c89c - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 1 alert when merging 156fb5a into b04228a - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 1 alert when merging 1363890 into b04228a - view on LGTM.com new alerts:
Comment posted by LGTM.com |
…onent and remove unused components
This pull request introduces 1 alert when merging b3bfa67 into c6fbdd8 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 1 alert when merging 85cbb89 into c6fbdd8 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 1 alert when merging 50c9c0f into c6fbdd8 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This PR aims to change message list components setting their height fixed letting list height to be predictable and the pre-calculated for optimization pourposes.