IMN-745 - API Gateway - GET Agreement Purposes #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamellini
force-pushed
the
IMN-744-api-gateway-get-agreement-attributes
branch
from
926af8f
to
53f0b5c
Compare
ecamellini
changed the title
agreements/:agreementId/purposes
ecamellini
force-pushed
the
IMN-745-api-gateway-get-agreement-purposes
branch
from
fa02a85
to
ca88d3e
Compare
ecamellini
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
ecamellini
changed the title
agreements/:agreementId/purposes
Carminepo2
approved these changes
Sep 6, 2024
ecamellini
force-pushed
the
IMN-744-api-gateway-get-agreement-attributes
branch
from
6214234
to
35f6c8b
Compare
ecamellini
force-pushed
the
IMN-745-api-gateway-get-agreement-purposes
branch
2 times, most recently
from
67441a9
to
2444d22
Compare
ecamellini
force-pushed
the
IMN-744-api-gateway-get-agreement-attributes
branch
from
321daf0
to
4e9aadc
Compare
ecamellini
force-pushed
the
IMN-745-api-gateway-get-agreement-purposes
branch
from
2444d22
to
7ceb6f8
Compare
beetlecrunch
approved these changes
Sep 11, 2024
ecamellini
force-pushed
the
IMN-744-api-gateway-get-agreement-attributes
branch
from
4e9aadc
to
843c98a
Compare
Base automatically changed from
IMN-744-api-gateway-get-agreement-attributes
to
main
September 11, 2024 15:55
ecamellini
force-pushed
the
IMN-745-api-gateway-get-agreement-purposes
branch
from
7ceb6f8
to
7136f11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopens #783
Based on #904
Closes IMN-745
Testing
Success case ✅
I have the following purposes in the readmodel
And the following agreement
With the same consumerId / eserviceId used for the purposes above.
The call returns only the ACTIVE / SUSPENDED versions ✅
Error case for agreement not found ❌
This error "bubbles up" from the agreement process API call response:
