Node 20 GH action CI #541
Merged
Node 20 GH action CI #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viktor-K
requested review from
micdes-pagopa,
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
ecamellini
approved these changes
May 21, 2024
micdes-pagopa
approved these changes
May 21, 2024
gabro
reviewed
May 21, 2024
There was a problem hiding this comment.
one other option to explore, is to use the engine field in the top-level package.json and use node-version-file: package.json in the setup-node action.
This way we can have a central point where the Node version is set (and we could potentially enforce it locally with engine-strict, if we wanted to)
gabro
reviewed
May 21, 2024
.github/workflows/pr.yml
Outdated
| @@ -51,7 +51,7 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 18 | |||
| node-version-file: .package.json | |||
AsterITA
approved these changes
May 22, 2024
galales
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update GH action using node 20
Addition add
.turbofolder to gitignore