-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 20 GH action CI #541
Node 20 GH action CI #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one other option to explore, is to use the engine
field in the top-level package.json
and use node-version-file: package.json
in the setup-node action.
This way we can have a central point where the Node version is set (and we could potentially enforce it locally with engine-strict, if we wanted to)
.github/workflows/pr.yml
Outdated
@@ -51,7 +51,7 @@ jobs: | |||
- uses: actions/checkout@v3 | |||
- uses: actions/setup-node@v3 | |||
with: | |||
node-version: 18 | |||
node-version-file: .package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the dot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover 🤦🏻
Update GH action using node 20
Addition add
.turbo
folder to gitignore