IMN 473 - Replace express winston middleware

[MalpenZibo]

Re-add the logger middleware removed here #423

NOTE:
With this new logger middleware, we're unable to add a log to the /health request

NEW format

[MalpenZibo]

Here we have to decide what we want to log.

[ecamellini]

Shouldn't we log the same info that we were logging with the previous middleware?

[MalpenZibo]

The old configuration was temporary so we could decide here the final version

[galales]

few considerations:

• I like the idea of having one log before and one after the call, it's easier to read. On the other side, this would reflect in a 50% log increase for the GETs, which are the most frequent called endpoints. Since Cloudwatch costs are not negligible, and considering that the double log does not actually add information, I would keep only the log at the request completion
• considering that the logger is already adding all context details, we can keep the previous log format
  Request {method} {urlWithParameters} - Response {code}
  Notes:
  • we need to include query and path parameters but not elements in the body, which can be sensitive
  • the previous log includes also the response status message. It does not actually add any information and we could remove it, but I've not strong opinions on this

cc @beetlecrunch

[ecamellini]

LGTM as long as we log the same info we were logging with the previous solution (or agree on a new set of info to log)

[Carminepo2]

Could we remove the anys?
My proposal:

Suggested change

	export function loggerMiddleware(serviceName: string) {
	return (req: any, res: any, next: express.NextFunction): void => {
	const loggerMetadata: LoggerMetadata = {
	serviceName,
	userId: req.ctx?.authData?.userId,
	organizationId: req.ctx?.authData?.organizationId,
	correlationId: req.ctx?.correlationId,
	};
	export function loggerMiddleware(serviceName: string): express.RequestHandler {
	return (req, res, next): void => {
	const context = (req as express.Request & { ctx?: AppContext }).ctx;
	const loggerMetadata: LoggerMetadata = {
	serviceName,
	userId: context?.authData?.userId,
	organizationId: context?.authData?.organizationId,
	correlationId: context?.correlationId,
	};

This way, if the AppContext changes we would be "notified" by typescript at compile time