IMN-608 - Fixing error in contract creation in case of attribute not …

…found (#612)
pagopa · Jun 5, 2024 · b1da93b · b1da93b
1 parent c35e9cb
commit b1da93b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/packages/agreement-process/src/model/domain/errors.ts b/packages/agreement-process/src/model/domain/errors.ts
@@ -10,6 +10,7 @@ import {
   makeApiProblemBuilder,
   UserId,
   SelfcareId,
+  AttributeId,
 } from "pagopa-interop-models";
 
 export const errorCodes = {
@@ -297,3 +298,13 @@ export function userNotFound(
     title: "User not found",
   });
 }
+
+export function attributeNotFound(
+  attributeId: AttributeId
+): ApiError<ErrorCodes> {
+  return new ApiError({
+    detail: `Attribute ${attributeId} not found`,
+    code: "attributeNotFound",
+    title: "Attribute not found",
+  });
+}
diff --git a/packages/agreement-process/src/services/agreementContractBuilder.ts b/packages/agreement-process/src/services/agreementContractBuilder.ts
@@ -24,7 +24,6 @@ import {
   VerifiedTenantAttribute,
   UserId,
   generateId,
-  genericError,
   tenantAttributeType,
   unsafeBrandId,
   AgreementDocument,
@@ -38,6 +37,7 @@ import {
   agreementMissingUserInfo,
   agreementSelfcareIdNotFound,
   agreementStampNotFound,
+  attributeNotFound,
   userNotFound,
 } from "../model/domain/errors.js";
 import { UpdateAgreementSeed } from "../model/domain/models.js";
@@ -105,7 +105,7 @@ const getAttributeInvolved = async (
           tenantAttribute.id
         );
         if (!attribute) {
-          throw genericError(`Attribute ${tenantAttribute.id} not found`);
+          throw attributeNotFound(tenantAttribute.id);
         }
         return [attribute, tenantAttribute as unknown as T];
       })