PIN-3519 Alignment to Selfcare API v.2 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nttdata-rtorsoli
requested review from
beetlecrunch and
galales
as code owners
nttdata-rtorsoli
changed the title
beetlecrunch
requested changes
Oct 30, 2023
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/ClientsApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
galales
reviewed
Oct 30, 2023
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
| @@ -4757,17 +4739,17 @@ paths: | |||
| schema: | |||
| type: integer | |||
| description: Time interval in milliseconds. Allowed requests will be constantly replenished during the interval. At the end of the interval the max allowed requests will be available | |||
| '/relationships/{relationshipId}': | |||
| '/users/{userId}': | |||
There was a problem hiding this comment.
@ruggerocastagnola this endpoint is a bit changed now that we have the userId.
What does the frontend need here? Just the info of a specific user or the info of the user related to a Tenant (eg name and roles)?
There was a problem hiding this comment.
What is the difference? The minimal set of info needed about a user in all related endpoints are:
- name
- surname
- id
- role on platform
Right now we also have the tax code but that is not mandatory, in case
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
galales
reviewed
Oct 31, 2023
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/ClientsApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/ClientsApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/ClientsApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/SelfcareApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: nttdata-rtorsoli <riccardo.torsoli@emeal.nttdata.com>
beetlecrunch
approved these changes
Nov 2, 2023
galales
requested changes
Nov 7, 2023
src/main/scala/it/pagopa/interop/backendforfrontend/api/impl/ClientsApiServiceImpl.scala
Outdated
Show resolved
Hide resolved
galales
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs PIN-3518, PIN-3515, PIN-4112 to compile