[DEV-2750] add migration to switch ck editor components with ck editor html components in tutorial parts #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarBert
requested review from
MarcoPonchia,
marcobottaro and
tommaso1
as code owners
|
|
marcobottaro
requested changes
Sep 16, 2025
...database/migrations/2025.15.09T12.00.00.substitute-ckeditor-parts-with-ckeditorhtml-parts.js
Outdated
Show resolved
Hide resolved
...database/migrations/2025.15.09T12.00.00.substitute-ckeditor-parts-with-ckeditorhtml-parts.js
Outdated
Show resolved
Hide resolved
Co-authored-by: marcobottaro <39835990+marcobottaro@users.noreply.github.com>
…tute-ckeditor-parts-with-ckeditorhtml-parts.js Co-authored-by: marcobottaro <39835990+marcobottaro@users.noreply.github.com>
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2750 |
There was a problem hiding this comment.
We should use English for comments in the repository 😉
marcobottaro
requested changes
Oct 8, 2025
Comment on lines
+17
to
+19
| // La creazione della tabella è fatta una sola volta, quindi può rimanere qui. | ||
| // Nota: lo script originale mischiava `knex` e `strapi.db.connection`. | ||
| // Per coerenza, usiamo `knex` anche qui. |
6 tasks
Sebastiano-Bertolin
requested changes
Oct 17, 2025
There was a problem hiding this comment.
I think the date in the name of the file should be formatted "YYYY.MM.DD..." by standard ISO 8601
| const tableExists = await knex.schema.hasTable('tutorials_components'); | ||
|
|
||
| if (!tableExists) { | ||
| console.log("'tutorials_components' table does not exist. Skipping migration."); |
There was a problem hiding this comment.
We could use console.warn here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #19
List of Changes
Add a migration to switch ck editor components with ck editor html components in tutorial parts
Motivation and Context
How Has This Been Tested?
on localhost
Screenshots (if appropriate):
Types of changes
Checklist: