Fix migration Issue #8
Conversation
laxman-aqw
requested review from
Nijarshrestha,
arjandhakal,
noxiousghost and
pratham-outside
|
Fix conflicts |
| @Entity('email_verifications') | ||
| export class EmailVerification { | ||
| @PrimaryGeneratedColumn('uuid') | ||
| id: string; |
There was a problem hiding this comment.
readonly id :string,
make all column names readonly.
fixed |
src/auth/auth.service.ts
Outdated
| const user = await this.userRepository.findOne({ where: { email } }); | ||
| const user = await this.userService.findOneByField('email', email); | ||
| if (!user) { | ||
| throw new BadRequestException('User not found'); |
There was a problem hiding this comment.
Maybe NotFoundException would be better here as well
There was a problem hiding this comment.
Thank you updated
src/auth/auth.service.ts
Outdated
| } | ||
|
|
||
| if (user.verifiedAt) { | ||
| throw new BadRequestException('User is already verified'); |
There was a problem hiding this comment.
Please aslo do check if ConflictException could work here
There was a problem hiding this comment.
thanks. updated
src/auth/auth.service.ts
Outdated
| }, | ||
| }); | ||
| const user = await this.userService.findOneByField('email', payload.email); | ||
| if (!user) throw new Error('User not found'); |
There was a problem hiding this comment.
As I have also been suggested; that the below structure would be better for readability.
| if (!user) throw new Error('User not found'); | |
| if (!user) | |
| { | |
| throw new Error('User not found'); | |
| } |
There was a problem hiding this comment.
updated thank you
src/auth/auth.service.ts
Outdated
| throw new BadRequestException('User not found'); | ||
| } | ||
|
|
||
| if (user.verifiedAt === null) { |
There was a problem hiding this comment.
Maybe you could also consider if (!user.verifiedAtl) to keep flexibility for other falsy values like NaN, undefined, 0,etc.
There was a problem hiding this comment.
thank you updated.
There was a problem hiding this comment.
Maybe you could also add @IsString decorators so that the validation pipe could validate it before reaching the controller
There was a problem hiding this comment.
thank you. the dtos are validated well in the feat-refactor branch
Uh oh!
There was an error while loading. Please reload this page.