[Bug] Moved code preventing MBH's transfer to post modifier generation

[frutescens]

What are the changes the user will see?

MBH will no longer be able to be stolen from the opponent.

Why am I making these changes?

Bug report https://discord.com/channels/1125469663833370665/1300228174151680040

What are the changes from a developer perspective?

Code moved down to correct location.

How to test the changes?

Try to steal MBH when generated.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)

[flx-sta]

Except that 1 comment lgtm

[PigeonBar]

It turns out that even with this fix, MBH becomes stealable again after reloading, because when the session data gets saved and reloaded, PersistentModifierData doesn't keep track of whether or not each individual modifier was set to be transferrable.

20241112.Stealable.MBH.mp4

[frutescens]

@PigeonBar I think I decided just to stop a potential transfer of MBH at the heart of the code - tryTransferModifier(). Not sure if it leads to other problems though.

[PigeonBar]

The issue is that tryTransferHeldItemModifier() is used in many places in the code. For example, your new changes would prevent transferring an MBH between party members during the rewards screen.

Some possible other approaches to fixing the bug:

1. Give held items an isStealable property separate from isTransferrable -- This is needed anyway in the long run, but would also require more care and effort.
2. Set the MBH to be non-transferrable during EncounterPhase.end() -- this runs after the MBH is generated, and it also runs no matter whether or not there was a reload.