[Beta][Bug] Move Phase not Ending Correctly

[frutescens]

What are the changes the user will see?

Move Phase should end correctly if the move fails.

Why am I making these changes?

My bug...

What are the changes from a developer perspective?

Removed the conditional requiring the PP Used to be greater than the move's max PP.

Screenshots/Videos

Situation 1:

Screen.Recording.2024-11-11.at.12.04.49.PM.mov

Situation 2:

Screen.Recording.2024-11-11.at.12.06.56.PM.mov

How to test the changes?

Situation 1:

1. Faint a Pokemon
2. Progress through the next waves as normal.

Situation 2:

1. Attempt to run away from a double battle with a Pokemon that has the ability run away, but have the first Pokemon use a move.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[MokaStitcher]

What's the reason behind the PP check removal?
In the original PR it was changed from && to ||
And now fully removed, is it because it's not necessary anymore to check that here? The comment specifically refers to pp stuff too so if it's not needed we might as well remove it

[frutescens]

What's the reason behind the PP check removal? In the original PR it was changed from && to || And now fully removed, is it because it's not necessary anymore to check that here? The comment specifically refers to pp stuff too so if it's not needed we might as well remove it

It was because the failure check from before specifically checked if the Pokemon was attempting to use a charge move, but had the charge move's PP decrease to 0 during its "charging state" from Spite so it would print out the failure message in that only specific situation. However, the charge move would be unable to be used (move.canUse() -> false) and move phase would end regardless, so I decided that it would be better to remove the check as a whole.

[MokaStitcher]

For reference. Was introduced in PR #4839
Related bug reports on discord here and here