[Refactor][Localization] Better handling for StatusEffect.NONE
with i18n
#4405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this inconvenience for translators with @CodeTappert
What are the changes the user will see?
None
Why am I making these changes?
Currently there is the necessity in translation of a few empty keys.
Quite inconvenient and useless. Reason for that is to handle the theoretical situation of
statusEffect:none.<obtain | heal etc.>
Which realistically never occurs afaikWhat are the changes from a developer perspective?
getStatusEffect<...>Text()
methods now check forStatusEffect.NONE
to simply return an empty-string""
status-effect.json
file/sHow to test the changes?
You can't really. Just set a status and remove it again and see if something odd happens.
Example Overrides
Checklist
beta
as my base branchnpm run test
)