Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Don't spawn lures if that lure still has 60% or more of its duration left #4354

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

Fontbane
Copy link
Contributor

What are the changes the user will see?

  • Lures no longer show up as rewards if you have a lure of the same type and 60% or more of its duration left
  • For example, green lures won't spawn if you have a green lure active with a remaining wave count of 6 or more. Once it hits 5 waves remaining, greens will show up again.
  • Super Lures will show up with 8 or less waves remaining, and Max Lures with 17 or less.

Why am I making these changes?

  • Since same-type Lure stacking is dead, it doesn't make sense to get spammed with lures to top off the one you got 3 waves ago

What are the changes from a developer perspective?

  • Adds a new lureWeightFunc to modifier-types.ts
  • This is used for all 3 lure types

Screenshots/Videos

With change:
Screenshot_901
Same wave but without change:
Screenshot_902

How to test the changes?

  • In modifier-types.ts, line 1629, change the 2 to a 20, increasing the weight of green lures 10x
  • Pick up a green lure and notice it doesn't spawn more until you hit 5 on it

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Fontbane Fontbane requested a review from a team as a code owner September 21, 2024 00:32
@damocleas damocleas added the Balance Team Specifically a balance team change label Sep 21, 2024
@CodeTappert CodeTappert merged commit 23b64b9 into pagefaultgames:beta Sep 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Team Specifically a balance team change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants