-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Flash Fire/etc now trigger even if the attack would miss #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flx-sta
changed the title
[Bug Fix] Fix for Moves That would be nullified by Move/type Absorbing Abilities Can Miss Incorrectly #3673
[P2] Fix for Moves That would be nullified by Move/type Absorbing Abilities Can Miss Incorrectly #3673
Sep 20, 2024
DayKev
reviewed
Sep 20, 2024
DayKev
previously approved these changes
Sep 21, 2024
DayKev
approved these changes
Sep 23, 2024
DayKev
changed the title
[P2] Fix for Moves That would be nullified by Move/type Absorbing Abilities Can Miss Incorrectly #3673
[Bug] Flash Fire/etc now trigger even if the attack would miss
Sep 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3673
What are the changes the user will see?
Should now properly use absorbing abilities even when attack misses under the hood
Why am I making these changes?
bugfix
What are the changes from a developer perspective?
modified several tests (such as flash fire, sap sipper, volt absorb, etc...) to account for when a pokemon misses an attack that should be absorbed
In ability.ts added a getter to get type immunity in TypeImmunityAbAttr
In move-effect-phase.ts added a check during hit checks for if a pokemon is immune to attacking move due to ability
Screenshots/Videos
2024-09-19.18-32-33.mp4
Same settings but changed to water gun as attack to see that volt absorb doesnt get confused for water absorb
https://github.com/user-attachments/assets/bb8714c3-d86c-412c-b3c1-b85627832c14
How to test the changes?
Use override files and change hitcheck function to return false
Also use the unit tests I modified
Checklist
beta
as my base branchnpm run test
)