Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Flash Fire/etc now trigger even if the attack would miss #4337

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

PrabbyDD
Copy link
Contributor

Fix for #3673

What are the changes the user will see?

Should now properly use absorbing abilities even when attack misses under the hood

Why am I making these changes?

bugfix

What are the changes from a developer perspective?

modified several tests (such as flash fire, sap sipper, volt absorb, etc...) to account for when a pokemon misses an attack that should be absorbed

In ability.ts added a getter to get type immunity in TypeImmunityAbAttr
In move-effect-phase.ts added a check during hit checks for if a pokemon is immune to attacking move due to ability

Screenshots/Videos

2024-09-19.18-32-33.mp4

Same settings but changed to water gun as attack to see that volt absorb doesnt get confused for water absorb
https://github.com/user-attachments/assets/bb8714c3-d86c-412c-b3c1-b85627832c14

How to test the changes?

Use override files and change hitcheck function to return false
Also use the unit tests I modified

Checklist

  • [X ] I'm using beta as my base branch
  • [ X] There is no overlap with another PR?
  • [ X] The PR is self-contained and cannot be split into smaller PRs?
  • [X ] Have I provided a clear explanation of the changes?
  • [ X] Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • [X ] Have I tested the changes (manually)?
    • [X ] Are all unit tests still passing? (npm run test)
  • [X ] Are the changes visual?
    • [X ] Have I provided screenshots/videos of the changes?

@flx-sta flx-sta added the P2 Bug Minor. Non crashing Incorrect move/ability/interaction label Sep 20, 2024
@flx-sta flx-sta changed the title [Bug Fix] Fix for Moves That would be nullified by Move/type Absorbing Abilities Can Miss Incorrectly #3673 [P2] Fix for Moves That would be nullified by Move/type Absorbing Abilities Can Miss Incorrectly #3673 Sep 20, 2024
DayKev
DayKev previously approved these changes Sep 21, 2024
@DayKev DayKev changed the title [P2] Fix for Moves That would be nullified by Move/type Absorbing Abilities Can Miss Incorrectly #3673 [Bug] Flash Fire/etc now trigger even if the attack would miss Sep 23, 2024
@DayKev DayKev added the Ability Affects an ability label Sep 23, 2024
@Tempo-anon Tempo-anon merged commit 3d4eadb into pagefaultgames:beta Sep 23, 2024
14 checks passed
@PrabbyDD PrabbyDD deleted the prabbyd3673 branch September 23, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Moves That would be nullified by Move/type Absorbing Abilities Can Miss Incorrectly
4 participants