Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adds Expert Pokemon Breeder Mystery Encounter to the game #4328

Merged
merged 8 commits into from
Sep 19, 2024

Conversation

ben-lear
Copy link
Collaborator

@ben-lear ben-lear commented Sep 19, 2024

What are the changes the user will see?

Adds a new ME called "The Expert Pokemon Breeder"

See Issue: #3818

Why am I making these changes?

Final Ultra ME that was being added for release

What are the changes from a developer perspective?

Screenshots/Videos

chrome_yDXCPLQlea.mp4
chrome_sfQhHuzTco.mp4

How to test the changes?

can run locally and set MYSTERY_ENCOUNTER_OVERRIDE to MysteryEncounterType.THE_EXPERT_BREEDER (and set MYSTERY_ENCOUNTER_RATE_OVERRIDE to 256, and be on a valid ME wave)

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

Adri1
Adri1 previously approved these changes Sep 19, 2024
@ben-lear ben-lear added the Mystery Encounter Mystery Encounters and related work label Sep 19, 2024
CodeTappert
CodeTappert previously approved these changes Sep 19, 2024
@ben-lear ben-lear changed the title Adds Expert Breeder Mystery Encounter to the game Adds Expert Pokemon Breeder Mystery Encounter to the game Sep 19, 2024
@ben-lear ben-lear changed the title Adds Expert Pokemon Breeder Mystery Encounter to the game [Feature] Adds Expert Pokemon Breeder Mystery Encounter to the game Sep 19, 2024
@ben-lear ben-lear added the Enhancement New feature or request label Sep 19, 2024
@DayKev
Copy link
Collaborator

DayKev commented Sep 19, 2024

const overrides = {
  MYSTERY_ENCOUNTER_RATE_OVERRIDE: 256,
  MYSTERY_ENCOUNTER_OVERRIDE: MysteryEncounterType.THE_EXPERT_BREEDER,
  STARTING_WAVE_OVERRIDE: 11,
  STARTING_LEVEL_OVERRIDE: 10
} satisfies Partial<InstanceType<typeof DefaultOverrides>>;

It didn't appear when I used these overrides, instead I got the Wobuffet ME (then after starting a new run I got some Oricorio ME).

@CodeTappert CodeTappert merged commit 7490699 into pagefaultgames:beta Sep 19, 2024
14 checks passed
@ben-lear ben-lear deleted the expert-breeder branch October 2, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Mystery Encounter Mystery Encounters and related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants