-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Adds Expert Pokemon Breeder Mystery Encounter to the game #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adri1
previously approved these changes
Sep 19, 2024
DayKev
reviewed
Sep 19, 2024
src/test/mystery-encounter/encounters/the-expert-breeder-encounter.test.ts
Outdated
Show resolved
Hide resolved
CodeTappert
previously approved these changes
Sep 19, 2024
ben-lear
changed the title
Adds Expert Breeder Mystery Encounter to the game
Adds Expert Pokemon Breeder Mystery Encounter to the game
Sep 19, 2024
ben-lear
changed the title
Adds Expert Pokemon Breeder Mystery Encounter to the game
[Feature] Adds Expert Pokemon Breeder Mystery Encounter to the game
Sep 19, 2024
CodeTappert
approved these changes
Sep 19, 2024
damocleas
approved these changes
Sep 19, 2024
DayKev
reviewed
Sep 19, 2024
src/test/mystery-encounter/encounters/the-expert-breeder-encounter.test.ts
Show resolved
Hide resolved
const overrides = {
MYSTERY_ENCOUNTER_RATE_OVERRIDE: 256,
MYSTERY_ENCOUNTER_OVERRIDE: MysteryEncounterType.THE_EXPERT_BREEDER,
STARTING_WAVE_OVERRIDE: 11,
STARTING_LEVEL_OVERRIDE: 10
} satisfies Partial<InstanceType<typeof DefaultOverrides>>; It didn't appear when I used these overrides, instead I got the Wobuffet ME (then after starting a new run I got some Oricorio ME). |
Adri1
approved these changes
Sep 19, 2024
DayKev
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Adds a new ME called "The Expert Pokemon Breeder"
See Issue: #3818
Why am I making these changes?
Final Ultra ME that was being added for release
What are the changes from a developer perspective?
Screenshots/Videos
chrome_yDXCPLQlea.mp4
chrome_sfQhHuzTco.mp4
How to test the changes?
can run locally and set
MYSTERY_ENCOUNTER_OVERRIDE
toMysteryEncounterType.THE_EXPERT_BREEDER
(and setMYSTERY_ENCOUNTER_RATE_OVERRIDE
to 256, and be on a valid ME wave)Checklist
beta
as my base branchnpm run test
)