Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fixing crash that can occur when loading variant sprite, #4315

Merged

Conversation

podarsmarty
Copy link
Contributor

@podarsmarty podarsmarty commented Sep 18, 2024

What are the changes the user will see?

  • Crash will no longer happen

Why am I making these changes?

  • Game can crash when failing to load variant sprites

What are the changes from a developer perspective?

How to test the changes?

  • Turn on experimental sprites.
  • With the following save, after evolving can observe the error. With loading from website response error handling will work. However, if an error is thrown without a response then crash happens (ie - happens in the offline client more readily)
    sessionData_Guest-evolve-crash.prsv.zip

Bug reports

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@podarsmarty podarsmarty force-pushed the experimental_variation_load_crash branch from 9275204 to 88203da Compare September 18, 2024 15:27
@podarsmarty podarsmarty marked this pull request as ready for review September 18, 2024 15:29
@podarsmarty podarsmarty requested a review from a team as a code owner September 18, 2024 15:29
@podarsmarty podarsmarty marked this pull request as draft September 18, 2024 17:33
@Madmadness65 Madmadness65 added Sprite/Animation For when graphics are incorrect P1 Bug Major. Game crashing move/ability/interaction labels Sep 18, 2024
@podarsmarty podarsmarty force-pushed the experimental_variation_load_crash branch 7 times, most recently from f1cd604 to 4765817 Compare September 18, 2024 21:28
@podarsmarty podarsmarty marked this pull request as ready for review September 19, 2024 00:00
@podarsmarty
Copy link
Contributor Author

Should be behaving properly. when testing i noticed some weirdness with experimental variation loading. will put up a separate pr for that

@podarsmarty
Copy link
Contributor Author

hmm tests are failing on CI but fine on local. taking a look. not sure whats happening yet

@podarsmarty podarsmarty force-pushed the experimental_variation_load_crash branch from f76504a to 2f0087f Compare September 19, 2024 17:27
@Tempo-anon Tempo-anon merged commit b17b1d6 into pagefaultgames:beta Nov 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Bug Major. Game crashing move/ability/interaction Sprite/Animation For when graphics are incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants