-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fixing crash that can occur when loading variant sprite, #4315
Merged
Tempo-anon
merged 3 commits into
pagefaultgames:beta
from
podarsmarty:experimental_variation_load_crash
Nov 3, 2024
Merged
[Bug] Fixing crash that can occur when loading variant sprite, #4315
Tempo-anon
merged 3 commits into
pagefaultgames:beta
from
podarsmarty:experimental_variation_load_crash
Nov 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podarsmarty
force-pushed
the
experimental_variation_load_crash
branch
from
September 18, 2024 15:27
9275204
to
88203da
Compare
Madmadness65
added
Sprite/Animation
For when graphics are incorrect
P1 Bug
Major. Game crashing move/ability/interaction
labels
Sep 18, 2024
podarsmarty
force-pushed
the
experimental_variation_load_crash
branch
7 times, most recently
from
September 18, 2024 21:28
f1cd604
to
4765817
Compare
Should be behaving properly. when testing i noticed some weirdness with experimental variation loading. will put up a separate pr for that |
10 tasks
podarsmarty
force-pushed
the
experimental_variation_load_crash
branch
from
September 19, 2024 00:53
497eaf6
to
f76504a
Compare
hmm tests are failing on CI but fine on local. taking a look. not sure whats happening yet |
podarsmarty
force-pushed
the
experimental_variation_load_crash
branch
from
September 19, 2024 17:27
f76504a
to
2f0087f
Compare
frutescens
approved these changes
Nov 2, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P1 Bug
Major. Game crashing move/ability/interaction
Sprite/Animation
For when graphics are incorrect
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Why am I making these changes?
What are the changes from a developer perspective?
How to test the changes?
sessionData_Guest-evolve-crash.prsv.zip
Bug reports
Checklist
beta
as my base branchnpm run test
)