-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Challenge] Add Nuzlocke-related challenges #4311
base: beta
Are you sure you want to change the base?
Conversation
Add `SelectModifierPhase` on waves 10, 20, ... if "No Auto Heal" challenge is active
This allows capture on the X2 wave instead
8172200
to
d381734
Compare
I see it picks 3 random people to request for review now lmao. Anyway, more or less ready (still need to figure out some tests). Could use some opinions on the challenge names/descriptions, I didn't spend long on them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you edit challengeParser() in run-info-ui-handler to process these new challenges?
Question: "Hardcore" mode also prevent the Pokémon to be heald every 10 waves, or it only applies to reviving items? |
It only prevents reviving, non-fainted Pokémon will still be healed if only Hardcore is active. |
Co-authored-by: Leo Kim <47556641+KimJeongSun@users.noreply.github.com>
…into nuzlocke-update
Add helper function to set pokeballs override Update tsdocs for overrides helpers
…into nuzlocke-update
What are the changes the user will see?
Adds 4 new challenges:
Why am I making these changes?
Nuzlocke mode is a popular request/on the roadmap.
What are the changes from a developer perspective?
6 new
ChallengeType
s were added:NO_HEAL_PHASE
Checks if the heal phase after every 10th wave should be activated. See
src/phases/party-heal-phase.ts
SHOP_ITEM_BLACKLIST
Filters the shop for specific items. See
src/modifier/modifier-type.ts
andsrc/ui/modifier-select-ui-handler.ts
RANDOM_ITEM_BLACKLIST
Filters the random item selection for specific items. See
src/modifier/modifier-type.ts
ADD_POKEMON_TO_PARTY
Checks if the current caught Pokémon can be added to the party. See
src/phases/attempt-capture-phase.ts
MOVE_BLACKLIST
Checks if move the user wants to use is illegal for this challenge. See
src/phases/command-phase.ts
PREVENT_REVIVE
Checks if Pokémon can be revived. See
src/phases/party-heal-phase.ts
Screenshots/Videos
Starter filter with "No Legends" challenge active
Shop with "Hardcore" challenge active
Lack of auto-heal with "No Free Heal" challenge active
no.auto.heal.challenge.mp4
Caught Pokémon not going to party with "Limited Catch" challenge active
pokemon.doesn.t.go.to.party.mp4
How to test the changes?
Start a new challenge run with one or more of the challenges active.
Checklist
beta
as my base branchnpm run test
)[ ] Are the changes visual?