Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Being explicit in vite configuration for relative paths #4264

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

podarsmarty
Copy link

@podarsmarty podarsmarty commented Sep 15, 2024

What are the changes the user will see?

  • Should be no visible changes to the end user.
  • Simplifies the build process for the offline app so it no longer needs github to modify the index.html prior to packaging.

Why am I making these changes?

  • Simplify the build process for offline
  • Get it closer to online state by eliminating modifications needed

What are the changes from a developer perspective?

  • Being explicit for relative paths for vite configuration.

Screenshots/Videos

N/A

How to test the changes?

Build the package & run it

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@podarsmarty podarsmarty requested a review from a team as a code owner September 15, 2024 03:17
@podarsmarty podarsmarty changed the title Being explicit in vite configuration for relative paths [QoL] Being explicit in vite configuration for relative paths Sep 15, 2024
@DayKev DayKev changed the base branch from main to beta September 16, 2024 07:54
@DayKev DayKev changed the base branch from beta to main September 16, 2024 07:55
@DayKev
Copy link
Collaborator

DayKev commented Sep 16, 2024

Looks like you'll need to manually rebase this from beta branch too.

@podarsmarty podarsmarty requested review from a team as code owners September 16, 2024 16:10
@podarsmarty podarsmarty changed the base branch from main to beta September 16, 2024 16:13
@podarsmarty
Copy link
Author

oopsie, forgot about this guy. updated

@flx-sta flx-sta removed request for a team September 16, 2024 17:34
@flx-sta flx-sta removed request for a team September 16, 2024 17:34
@flx-sta flx-sta added Miscellaneous Changes that don't fit under any other label Enhancement New feature or request labels Sep 16, 2024
@CodeTappert CodeTappert merged commit 0dabf87 into pagefaultgames:beta Sep 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants