Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labeler configuration for localization #4145

Draft
wants to merge 1 commit into
base: beta
Choose a base branch
from
Draft

Add labeler configuration for localization #4145

wants to merge 1 commit into from
+16 −0

Conversation

f-fsantos
Copy link
Collaborator

What are the changes the user will see?

Why am I making these changes?

What are the changes from a developer perspective?

Screenshots/Videos

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@f-fsantos f-fsantos requested a review from a team as a code owner September 9, 2024 23:45
@CodeTappert
Copy link
Collaborator

So what does this actually do?

Tempo-anon
Tempo-anon reviewed Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@Tempo-anon Tempo-anon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where PR description

@flx-sta flx-sta marked this pull request as draft September 13, 2024 22:29
@flx-sta
Copy link
Collaborator

flx-sta commented Sep 13, 2024

@f-fsantos I've put into Draft since the PR template isn't filled out yet.
Feel free to put it back up for review as soon as the template is filled out

@flx-sta flx-sta added Enhancement New feature or request Localization Provides or updates translation efforts labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xavion3 Xavion3 Xavion3 left review comments

@flx-sta flx-sta flx-sta left review comments

@Tempo-anon Tempo-anon Tempo-anon left review comments

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Enhancement New feature or request Localization Provides or updates translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@f-fsantos @CodeTappert @flx-sta @Xavion3 @Tempo-anon