-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix Flash Fire not showing message upon activation #4063
base: beta
Are you sure you want to change the base?
Conversation
Uh, you forgot to add a description to the PR. |
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
The locales PR adding the line to flash fire is merged |
I think it's good, but apparently testing locales changes is difficult. Need to figure out how to force the locales update to appear locally... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flash Fire's message should be contained within its respective tag (i.e. in the onAdd
function). This implementation isn't really scalable since it only displays the right message when the attribute is used for Flash Fire
What are the changes the user will see?
Flash Fire will now send a Fire-boosting message once upon activation and an immunity message every time after.
Why am I making these changes?
Closes #4058
What are the changes from a developer perspective?
data/ability
: Added a condition inTypeImmunityAddBattlerTagAbAttr
(which only Flash Fire uses but whatever) to check if the effect has already been applied. If no, display the new Flash Fire message and if yes, display the standard immunity message.locales/en/ability-trigger
: Added new Flash Fire message that generalizes to any move type if required.Screenshots/Videos
Before
PreFix.mp4
After
AfterFix.mp4
How to test the changes?
Activate Flash Fire. I used overrides.
Checklist
beta
as my base branchnpm run test
)