Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fix/update invalid vite.config.ts #3531

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

flx-sta
Copy link
Collaborator

@flx-sta flx-sta commented Aug 13, 2024

What are the changes?

Fixing/Updating the existing vite.config.ts without changing any of it's behavior

Why am I doing these changes?

To resolve errors shown in the IDE

What did change?

Simply adding proper TS types to the objects and fixing the definition object so no more errors are shown in the IDE

How to test the changes?

  1. Open vite.config.ts
  2. Your IDE shouldn't complain anymore

  1. Open vitest.config.ts
  2. Your IDE shouldn't complain anymore

  1. open vitest.workspace.ts
  2. Your IDE shouldn't complain anymore

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)

- fix types
- update defintion to map `UserConfig` type
@flx-sta flx-sta added the (Legacy) Bug Legacy Label, don't apply to new issues/PRs label Aug 13, 2024
@flx-sta flx-sta changed the title [Bug] vite.config.ts invalid [Bug] fix/update invalidvite.config.ts Aug 13, 2024
@flx-sta flx-sta changed the title [Bug] fix/update invalidvite.config.ts [Bug] fix/update invalid vite.config.ts Aug 13, 2024
@flx-sta flx-sta added the Refactor Rewriting existing code related label Aug 13, 2024
@flx-sta flx-sta marked this pull request as ready for review August 13, 2024 09:43
@f-fsantos f-fsantos merged commit b7d7d9b into pagefaultgames:beta Aug 13, 2024
4 checks passed
@flx-sta flx-sta deleted the bug/vitest.confi-invalid branch August 13, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Legacy) Bug Legacy Label, don't apply to new issues/PRs Refactor Rewriting existing code related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants