[Optimization] Minify json files in build directory (after beta rebase) #3214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VITE UPDATE (v4 => v5)
I had to bump vite up to v5 due to this issue
vitejs/vite#15714
Otherwise
typedoc
would have failed constantly.Why does
typedoc
suddenly fail?Because I'm using node types inside my self-written json-minify plugin. To be exact the filesystem
fs
type. vite is "copying" those types but since node v18++ those copied type are out of date. The vite team hasn't migrated that fix into v4 yet and there is no indicator to do that yet.Duplicate of #3073
What are the changes?
it minifies all the json files in the given directorties (currently
/dist/images
and/dist/battle-anim
). That way we can work with the beautified jsons but the users retrieve the minified ones.Why am I doing these changes?
Reduce file-size load
What did change?
Added the
minifyJson
plugin to the vite.config.Screenshots/Videos
How to test the changes?
npm run build
/dist/images
and/dist/battle-anim
folders for json filesChecklist
npm run test
)