[Bug] Caught Pokemon Summary-Modifier Display Fix #3145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
Modifiers were not displaying on the caught pokemon's summary because of how the game stores and determines possession of modifiers. summary-ui-handler.ts now uses the pokemon's ownership boolean (pokemon.battleInfo.player) to determine where to look for modifiers.
Why am I doing these changes?
As a player, I would like to see the modifiers of my caught pokemon + my PR, my responsibility
What did change?
Screenshots/Videos
Screen.Recording.2024-07-25.at.9.46.37.AM.mov
How to test the changes?
Catch a wild Pokemon with modifiers with a full party and press the Summary Option
Checklist
beta
as my base branchnpm run test
)