Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Caught Pokemon Summary-Modifier Display Fix #3145

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

frutescens
Copy link
Collaborator

What are the changes?

Modifiers were not displaying on the caught pokemon's summary because of how the game stores and determines possession of modifiers. summary-ui-handler.ts now uses the pokemon's ownership boolean (pokemon.battleInfo.player) to determine where to look for modifiers.

Why am I doing these changes?

As a player, I would like to see the modifiers of my caught pokemon + my PR, my responsibility

What did change?

  • Temporary Pokemon object has tempPokemon.battleInfo.player set to false in phases.ts
  • summary-ui-handler.ts uses pokemon.battleInfo.player as an argument in findModifiers()

Screenshots/Videos

Screen.Recording.2024-07-25.at.9.46.37.AM.mov

How to test the changes?

Catch a wild Pokemon with modifiers with a full party and press the Summary Option

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon merged commit 233c926 into pagefaultgames:beta Jul 25, 2024
4 checks passed
@Madmadness65 Madmadness65 added the (Legacy) Bug Legacy Label, don't apply to new issues/PRs label Jul 25, 2024
@Tempo-anon Tempo-anon mentioned this pull request Jul 25, 2024
9 tasks
Vassiat pushed a commit to Vassiat/pokerogue that referenced this pull request Jul 26, 2024
* Fixed modifiers not displaying on summary screen

* Addressed Typedoc issues

* Documentation added

---------

Co-authored-by: Frutescens <info@laptop>
@frutescens frutescens deleted the modifierFix branch July 29, 2024 22:03
@frutescens frutescens restored the modifierFix branch July 29, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Legacy) Bug Legacy Label, don't apply to new issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants