-
Notifications
You must be signed in to change notification settings - Fork 3
remove sonar #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
remove sonar #385
Conversation
Por favor, catalogue-o seguindo as instruções nesta documentação. [Via VPN]. 💁 Qualquer problema ou dúvida, estamos no Slack, basta abrir um ticket no canal #help-foundation-platform. |
d9960bf
to
3c80d63
Compare
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
fa174eb
to
12a4f9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the SonarCloud integration and replaces the existing coverage & linter steps with LCOV-based reports and MegaLinter workflows.
- Swaps PHPUnit’s Clover XML output to LCOV format.
- Adds configuration for MegaLinter and jscpd.
- Introduces composite workflows for coverage reporting and MegaLinter.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
phpunit.xml | Changed Clover report output from clover.xml to lcov.info . |
.mega-linter.yml | Added MegaLinter configuration (enabled linters). |
.jscpd.json | Added plagiarism-check configuration with zero threshold. |
.github/workflows/mega-linter.yml | New composite workflow for MegaLinter. |
.github/workflows/coverage-report.yml | New composite workflow for LCOV coverage reporting. |
.github/workflows/ci.yml | Removed Sonar job, updated artifact paths, and wired new workflows. |
Comments suppressed due to low confidence (3)
.github/workflows/ci.yml:122
- Ensure the LCOV file is actually generated at this location. phpunit.xml now outputs
lcov.info
to the project root, so the CI upload path may not match and could fail.
path: magento/vendor/pagarme/pagarme-magento2-module/lcov.info
.github/workflows/ci.yml:138
- The composite workflow
mega-linter.yml
declares several required inputs without defaults, but this invocation only passesRUNS_ON
. You need to supply all required inputs or add defaults in the called workflow to prevent failures.
uses: ./.github/workflows/mega-linter.yml
.github/workflows/mega-linter.yml:7
- This input is defined without a default value, making it required for any call. Either provide a default here or ensure every caller supplies it to avoid workflow errors.
GRAFANA_API_REPORTER_URL:
type: number | ||
NAME_HTML_REPORT: | ||
type: string | ||
ALL_FILES_MINIMUN: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ALL_FILES_MINIMUN" is misspelled; it should be "ALL_FILES_MINIMUM" to maintain clarity and consistency.
ALL_FILES_MINIMUN: | |
ALL_FILES_MINIMUM: |
Copilot uses AI. Check for mistakes.
WORKING_DIRECTORY: ./ | ||
PROJECT: Magento2 Dashboard | ||
PR_MINIMUM: 0 | ||
NAME_HTML_REPORT: MAgento2 Coverage Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Typo in "MAgento2"; consider correcting to "Magento2 Coverage Report".
NAME_HTML_REPORT: MAgento2 Coverage Report | |
NAME_HTML_REPORT: Magento2 Coverage Report |
Copilot uses AI. Check for mistakes.
📦 Attachments (if appropriate)
Add additional informations like screenshots, issue link, etc
💬 Important guidelines