This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Fix trie lookup, added a test to ensure memoized function doesn't get… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much simpler, thanks! Could you please merge with master here as well? |
paf31
suggested changes
Apr 24, 2017
| modifyRef called (_ + 1) | ||
| pure $ fn n | ||
| quickCheck' 10000 $ \(SmallInt x) -> fn x == msin x | ||
| ncalled <- readRef called |
test/Main.purs
Outdated
| pure $ fn n | ||
| quickCheck' 10000 $ \(SmallInt x) -> fn x == msin x | ||
| ncalled <- readRef called | ||
| quickCheck' 1 $ ncalled < 2000 |
There was a problem hiding this comment.
You could use Test.Assert here and provide an error message.
test/Main.purs
Outdated
| @@ -18,12 +24,25 @@ data Ints | |||
| = Int1 Int | |||
| | Int2 Int | |||
|
|
|||
| derive instance genericInts :: Generic Ints _ | |||
| instance genericInts :: G.Generic Ints | |||
There was a problem hiding this comment.
Could you please leave this as-is? It should build with the compiler in master.
paf31
approved these changes
Apr 25, 2017
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… called too much