chore(deps): bump vite 8, vitest 4, @vitejs/plugin-react 6 (dev) - #15
Conversation
Consolidated regeneration of Dependabot PR #5 off current main: - vite ^6.0.0 -> ^8.0.16 (locks 8.1.5) - vitest ^3.0.7 -> ^4.1.8 (locks 4.1.10) - @vitejs/plugin-react ^4.5.0 -> ^6.0.2 (locks 6.0.4) - esbuild dropped as a direct/ancestor requirement (now optional peer of vite 8) Lockfile regenerated fresh off main to avoid the stale-base symfony-v8 lock that broke PR #5's original branch. Frontend gates green locally: typecheck, unit tests (8/8), vite build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hh2Lo6FAPGaVgRkpkE2YwW
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83fe50057e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "typescript": "^5.7.2", | ||
| "vite": "^6.0.0", | ||
| "vitest": "^3.0.7" | ||
| "vite": "^8.0.16", |
There was a problem hiding this comment.
Require the Vite 8 Node floor explicitly
With this bump, the locked Vite/plugin-react packages require Node ^20.19.0 || >=22.12.0 (package-lock.json:3131 and package-lock.json:835), while the repo still advertises only Node.js 20+ in README.md:188 and the CI matrix is just node: ["20"]. Environments on supported-looking Node 20.0–20.18 or 22.0–22.11 will now be outside Vite's supported engine range and can fail install/build depending on engine-strict/runtime checks, so please either declare/pin the new floor (docs/package engines/CI) or avoid the Vite 8 upgrade.
Useful? React with 👍 / 👎.
Consolidated, manually-regenerated replacement for Dependabot PR #5 (npm dev group), whose recreate queue was stuck and whose branch carried a stale base.
What changed
vite^6.0.0→^8.0.16(lock: 8.1.5)vitest^3.0.7→^4.1.8(lock: 4.1.10)@vitejs/plugin-react^4.5.0→^6.0.2(lock: 6.0.4)esbuilddropped as a direct/ancestor requirement (now an optional peer of vite 8)The
package-lock.jsonwas regenerated fresh off currentmain, so the stale symfony-v8 lock that made PR #5's original branch fail on PHP 8.3 is gone (main's lock pins symfony 7.4.x, php >=8.2 — installs cleanly on 8.3 and 8.4).Compatibility notes
vite.config.jscallsreact()with no Babel options, so@vitejs/plugin-reactv6 (Babel removed) needs no config change.^20.19 || >=22.12; CI uses Node 20 (setup-node@v4 resolves the latest 20.x, satisfying 20.19+).Local gates (green)
npm run typecheck✓npm run test:unit✓ (8/8)npm run build✓ (vite 8.1.5)Playwright browser download is blocked in the build sandbox; the
e2e/e2e:accessibilitygates run in CI, where the workflow installs browsers vianpx playwright install --with-deps chromium.Supersedes #5.
Generated by Claude Code