chore: added warning for message comparison and added handling when interactions array in null or undefined #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nteractions array in null or undefined
Saup21
changed the title
vwong
requested changes
Nov 7, 2025
Collaborator
vwong
left a comment
vwong
left a comment
There was a problem hiding this comment.
Add a changeset with npm run changeset:add. I think this should be a minor version.
vwong
reviewed
Nov 7, 2025
| for (const [index, interaction] of parsedInteractions.entries()) { | ||
| if (interaction._skip) { | ||
| // non http/synchronous have been zero-ed out | ||
| yield { |
Collaborator
There was a problem hiding this comment.
Minor nitpick. This is duplicated, can you extract this into a constant, so that the code here will look like:
yield UNSUPPORTED_INTERACTION;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PACT-5008