Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Provider Compatibility Suite #638

Merged
merged 6 commits into from
Mar 27, 2024
Merged

HTTP Provider Compatibility Suite #638

merged 6 commits into from
Mar 27, 2024

Conversation

JP-Ellis
Copy link
Contributor

📝 Summary

Implement HTTP provider compatibility suite for Pact specifications 2, 3 and 4.

🚨 Breaking Changes

🔥 Motivation

To help ensure consistency across Pact implementations.

🔨 Test Plan

As part of CI

🔗 Related issues/PRs

In preparation for the implementatino of the V2+ specs, refactor the V1
compatibility suite to share steps

Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis added area:tests Relating to the testing area:v3 Relating to the pact.v3 module type:chore Part of regular code upkeep labels Mar 27, 2024
@JP-Ellis JP-Ellis self-assigned this Mar 27, 2024
Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis merged commit c271ed4 into master Mar 27, 2024
16 of 26 checks passed
@JP-Ellis JP-Ellis deleted the chore/v2-http-provider branch March 27, 2024 04:46
@mefellows
Copy link
Member

WOOT! 👏

@JP-Ellis
Copy link
Contributor Author

JP-Ellis commented Mar 27, 2024

There's a bug with the Windows CI in which the provider server can never be reached... but it's a bit difficult for me to investigate right now. I'll create a ticket to track that though. This is tracked in #639.

The remaining failing tests will be fixed with the next FFI release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests Relating to the testing area:v3 Relating to the pact.v3 module type:chore Part of regular code upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4/http_provider.feature v3/http_provider.feature v2/http_provider.feature
2 participants