-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ffi provider #245
Feat/ffi provider #245
Conversation
6ea1717
to
488d55f
Compare
pact/ffi/ffi_verifier.py
Outdated
elif 'linux' in target_platform: | ||
libname = "./libpact_ffi-linux-x86_64.so" | ||
elif 'windows' in target_platform: | ||
libname = "libpact_ffi-osx-x86_64.dylib" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be .dll
for Windows
if 'windows' in platform.platform().lower(): | ||
fetch_lib(bin_path, suffix, 'dll') | ||
fetch_lib(bin_path, suffix, 'dll.lib') | ||
fetch_lib(bin_path, suffix, 'lib') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are using the DLL, you don't need the static lib (.lib). But there is no harm in downloading it, apart from it being the biggest one.
…e changes to docker37 which I will need to do to all
60ac756
to
cbf8ea0
Compare
cbf8ea0
to
050ee0e
Compare
Draft PR for FFI Provider work