Feat/ffi provider #245
Closed
Feat/ffi provider #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottmurray
force-pushed
the
feat/ffi-provider
branch
from
6ea1717
to
488d55f
Compare
uglyog
reviewed
Jul 19, 2021
pact/ffi/ffi_verifier.py
Outdated
| elif 'linux' in target_platform: | ||
| libname = "./libpact_ffi-linux-x86_64.so" | ||
| elif 'windows' in target_platform: | ||
| libname = "libpact_ffi-osx-x86_64.dylib" |
uglyog
reviewed
Jul 19, 2021
| if 'windows' in platform.platform().lower(): | ||
| fetch_lib(bin_path, suffix, 'dll') | ||
| fetch_lib(bin_path, suffix, 'dll.lib') | ||
| fetch_lib(bin_path, suffix, 'lib') |
There was a problem hiding this comment.
If you are using the DLL, you don't need the static lib (.lib). But there is no harm in downloading it, apart from it being the biggest one.
…e changes to docker37 which I will need to do to all
elliottmurray
force-pushed
the
feat/ffi-provider
branch
from
60ac756
to
cbf8ea0
Compare
elliottmurray
force-pushed
the
feat/ffi-provider
branch
from
cbf8ea0
to
050ee0e
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for FFI Provider work