Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all FFI methods relating to Pact #418

Closed
1 of 3 tasks
Tracked by #396
JP-Ellis opened this issue Oct 11, 2023 · 1 comment · Fixed by #439
Closed
1 of 3 tasks
Tracked by #396

Implement all FFI methods relating to Pact #418

JP-Ellis opened this issue Oct 11, 2023 · 1 comment · Fixed by #439
Assignees
Labels
area:v3 Relating to the pact.v3 module difficulty:easy A simple task appropriate for newcomers to the codebase smartbear-supported This issue is supported by SmartBear type:feature New feature

Comments

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Oct 11, 2023

Description

  • Implement all missing methods for the Pact class. The scope of 'all' here relates to the methods exposed by the FFI which typically either: construct a Pact (returning a PactHandle); or, take a PactHandle as an argument and modify the underlying Pact
  • Ensure all new methods are systematically unit-tested.

Has this been requested on Canny?

No

Motivation

Initial work implementing the Pact class was done as part of #410; however, the scope of the PR was limited to a MWE to ease with the review and ensure that the more substantive/foundational parts can be reviewed and the finer implementation details can kept separate.

Have you tried building it?

Continuation of prior work.

Self-service

  • I'd be willing to contribute this feature to Pact Python myself.
@JP-Ellis JP-Ellis added the smartbear-supported This issue is supported by SmartBear label Oct 11, 2023
@github-actions
Copy link

👋 Hi! The 'smartbear-supported' label has just been added to this issue, which will create an internal tracking ticket in PactFlow's Jira (PACT-1396). We will use this to prioritise and assign a team member to this task. All activity will be public on this ticket. For now, sit tight and we'll update this ticket once we have more information on the next steps.

See our documentation for more information.

@JP-Ellis JP-Ellis mentioned this issue Oct 11, 2023
48 tasks
@JP-Ellis JP-Ellis self-assigned this Oct 11, 2023
@JP-Ellis JP-Ellis added type:feature New feature difficulty:easy A simple task appropriate for newcomers to the codebase area:v3 Relating to the pact.v3 module labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:v3 Relating to the pact.v3 module difficulty:easy A simple task appropriate for newcomers to the codebase smartbear-supported This issue is supported by SmartBear type:feature New feature
Projects
Status: ✅ Completed
Development

Successfully merging a pull request may close this issue.

1 participant