Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Fixed some mistakes in exampleSite top menu #240

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

VincentTam
Copy link
Collaborator

Description

  1. added back French UI string for "Home". The code blocks below shows that that was missing in the past.

    [about]
    other = "A Propos"

    [[Languages.fr.menu.main]]
    name = "About"
    identifier = "about"
    url = "/about/"

  2. added back a proper localized language name for both Chinese (Simplified) and Chinese (Traditional) so that it makes sense.

    [Languages.zh-CN]
    LanguageCode = "zh-CN"
    LanguageName = "中文"
    weight = 7
    [Languages.zh-TW]
    LanguageCode = "zh-TW"
    LanguageName = "中文"
    weight = 8

Motivation and Context

To make the displayed text in the top menu bar and the language bar more sensible.

Screenshots (if appropriate):

Screenshot from 2021-03-09 15-16-57

The French version of my fork's exampleSite displays the Chinese lanuage names and the French translation of "About" ("A Propos") properly after I merged the branch for this PR to my source branch addGHCI for hosting exampleSite with GitHub Actions.

Checklist:

  • I have updated the documentation, as applicable.
  • I have updated the theme.toml, as applicable.

@VincentTam VincentTam changed the title Fixed some mistakes in site top menu Fixed some mistakes in exampleSite top menu Mar 9, 2021
@VincentTam VincentTam self-assigned this Mar 9, 2021
Copy link
Collaborator Author

@VincentTam VincentTam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge

@VincentTam VincentTam merged commit f1946b7 into pacollins:master Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant