-
Notifications
You must be signed in to change notification settings - Fork 194
New boolean param for user to choose to hide empty stats #176
Conversation
Ah, yes. Thanks, that logic is much more... logical. I should have seen that, considering how long I spent looking at it. Your markup was missing the initial Wiki entry: hideEmptyStats |
It did not work. But I can try to investigate why it didn’t. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once I get final approval from @RyanTG, I will go ahead and merge this.
I approve. Is that a more formal way for me to approve? If so, I'm not seeing it. |
Nah, I just am looking for a final comment to make sure that you have everything there. I have been known to move too quick, so I like that you guys are helping with development so I can force myself to slow down! I mean you could theoretically do a review in the |
Description
Adds logic to the stats file to hide stats, based on user preference, when two conditions are met: user prefers to hide them, and they are empty.
This logic had to be more complex (or busy-looking) than I originally envisioned. But this is the best I could come up with. The logic is way simpler when you simply enable this functionality, without giving the user a choice.
Motivation and Context
Currently, If a Tag or Category isn't populated, the icon is displayed and it says "None". This seems like noise to me. This PR gives the user the choice to hide the icon and text if none.
Checklist:
theme.toml
, as applicable.I updated the exampleSite config, and I included a comment describing it. If that is not preferable, I can remove the comment and add the text to the wiki.