Use default theme if localstorage value deleted manually #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al storage manual deletion)
DavidWells
changed the title
DavidWells
changed the title
|
I just ran into this same bug. It looks like a new version with this fix hasn't been published yet. Any chance you could release it soon? This is a great library. Thanks for all your work on it! |
|
Sorry for the delay, just published 0.0.15 with this fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey thanks for the project 😃
When you (or a user) deletes the localStorage value manually via dev tools or otherwise, the value is set as
nulland no themes are used.Example:
It seems like this should revert to defaultValue if it's set in the provider and never be set to null.