-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/testing #35
Feature/testing #35
Conversation
The testing-setup is based on: - jest - @testing-library/react
Amazing! This looks great, I'd be happy to merge already just to have some tests going on future PRs. A few more things we could add tests for:
|
Regarding the test you mentioned, I suppose it would be cool to check those with Integration Tests. Especially for the media-query based one. Cypress might work nicely for that. I'll add some improvements to the test and afterwards I'll open the PR to be merged. Thx for the feedback |
@pacocoursey I added a test-suite for the forcedTheme prop, however I am not completely sure if I used it the right way. |
@pacocoursey Would it be of interest to run the tests on every PR? |
No, currently the hook will return whatever the active theme is (generally the UI should reflect it), then
Yeah, for sure! I'll merge this and set this up to run in GH actions on every PR as a required step. |
Good stuff! Thanks for the pleasant conversations 👍🏻 |
Changes requested in Issue 12
This PR includes the following changes: