fix: fix toggle promobar state change to only happen when needed

packdigital · Oct 6, 2024 · 4e08b74 · 4e08b74
1 parent 50215ad
commit 4e08b74
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/app/components/Header/Promobar.tsx b/app/components/Header/Promobar.tsx
@@ -54,12 +54,13 @@ export function Promobar() {
   useEffect(() => {
     const setPromobarVisibility = () => {
       if (document.body.style.position === 'fixed') return;
-      togglePromobar(
+      const promobarShouldBeOpen =
         window.scrollY <=
-          (typeof promobarHeight === 'string'
-            ? parseInt(promobarHeight, 10)
-            : Number(promobarHeight)),
-      );
+        (typeof promobarHeight === 'string'
+          ? parseInt(promobarHeight, 10)
+          : Number(promobarHeight));
+      if (promobarOpen && !promobarShouldBeOpen) togglePromobar(false);
+      else if (!promobarOpen && promobarShouldBeOpen) togglePromobar(true);
     };
 
     if (!autohide) {
@@ -72,7 +73,7 @@ export function Promobar() {
     return () => {
       window.removeEventListener('scroll', setPromobarVisibility);
     };
-  }, [autohide, promobarHeight]);
+  }, [autohide, promobarHeight, promobarOpen]);
 
   return (
     <div