fix: Prevent crash when sending a post while media is uploading #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code used `filterIsInstance<Ok<UploadEvent.FinishedEvent>>()`. This can fail at runtime with class cast exception because the type in `Ok<...>` is erased so `filterIsInstance` was accepting any `Ok` `Result`. Later attempts to operate on it as a `.FinishedEvent` generated the run time error. Fix that by explicitly checking the type of the `Ok` result in `first` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code used
filterIsInstance<Ok<UploadEvent.FinishedEvent>>().This can fail at runtime with class cast exception because the type in
Ok<...>is erased sofilterIsInstancewas accepting anyOkResult. Later attempts to operate on it as a.FinishedEventgenerated the run time error.Fix that by explicitly checking the type of the
Okresult infirstinstead.