Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

horace_mex and issues with cpp_communicator #1753

Closed
abuts opened this issue Sep 27, 2024 · 1 comment
Closed

horace_mex and issues with cpp_communicator #1753

abuts opened this issue Sep 27, 2024 · 1 comment
Assignees
@abuts

Comments

@abuts
Copy link
Member

abuts commented Sep 27, 2024

users complain that loading Horace-4 from distribution and trying to install it on clean windows machine causes problem. cpp_communicator does not have all its references (dll-s) satisfied on the system.

To at least partially address this:

  1. make check for cpp_communicator an independent on other check_horace_mex checks to allow mex to be enabled regardless to mpi.
  2. add validation for cpp_communicator to attempt to enable mpi cluster (mpiexec_mpi)
  3. fix issues with horace_mex to allow users who is not familiar with cmake building libraries on their systems.
@abuts abuts self-assigned this Sep 27, 2024
abuts added a commit that referenced this issue Sep 27, 2024
@abuts
Re #1753 disable error for failing cpp_communicator in check_horace_m…
0d83998 
…ex.m
abuts added a commit that referenced this issue Sep 27, 2024
@abuts
Re #1753 disentangle parallel options and use_mex option
9f5efad
abuts added a commit that referenced this issue Sep 27, 2024
@abuts
Re #1753 fixed horace_mex using Matlab
c0f3a8d
abuts added a commit that referenced this issue Sep 27, 2024
@abuts
Re #1753 validated horace_mex_mpi
863beae
@abuts abuts mentioned this issue Sep 27, 2024
Merged
abuts added a commit that referenced this issue Sep 30, 2024
@abuts
Re #1753 should fix test_mpi_wrapper and better warning in ClusterSlu…
1ee8f78 
…rm.m and parallel_config.m
abuts added a commit that referenced this issue Sep 30, 2024
@abuts
Re #1753 disable error for failing cpp_communicator in check_horace_m…
d134296 
…ex.m
abuts added a commit that referenced this issue Sep 30, 2024
@abuts
Re #1753 disentangle parallel options and use_mex option
8cf800c
abuts added a commit that referenced this issue Sep 30, 2024
@abuts
Re #1753 fixed horace_mex using Matlab
58d12d1
abuts added a commit that referenced this issue Sep 30, 2024
@abuts
Re #1753 validated horace_mex_mpi
44d8d22
abuts added a commit that referenced this issue Sep 30, 2024
@abuts
Re #1753 should fix test_mpi_wrapper and better warning in ClusterSlu…
95ae066 
…rm.m and parallel_config.m

# Conflicts:
#	herbert_core/classes/MPIFramework/@ClusterSlurm/ClusterSlurm.m
abuts added a commit that referenced this issue Oct 2, 2024
@abuts
Re #1753 slightly better description of one new property
91a737d
abuts added a commit that referenced this issue Oct 3, 2024
@abuts
Re #1753 -- minor comments (typos) identified by review.
3ccf790
abuts added a commit that referenced this issue Oct 9, 2024
@abuts
Re #1753 remove redundant code unrelated to main topic of the ticket …
71f1a0b 
…(but related to the alignment ticket) and made to push the build with changed integration scripts
abuts added a commit that referenced this issue Oct 10, 2024
@abuts
Re #1753 changes from review. Couple of words about meaning of some v…
4205739 
…ariables
@abuts
Copy link
Member Author

abuts commented Oct 21, 2024

fixed through #1754

@abuts abuts closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuts abuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abuts