Fixes problems with algorithm #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I really liked your approach to implementing and explaining the A* algorithm.
Now, the problem is that the algorithm as it is does not work correctly. There are two issues:
See printout from example:
The cost is way too high, and all points are visited.
The root cause of the problem seems to be conflating the actual cost to reach a point with the estimated total cost of the path. This PR tries to make the difference clearer in README, and fixes the implementation by subtracting the previous heuristic before adding the new.
I understand that this repo is intended for demonstrating and teaching the principles, and should be kept as simple as possible (but correct!). If this understanding is incorrect, I can create a PR for another branch with larger changes that makes it usable for generic graphs and heuristics (not only grids).