Skip to content

Commit 5934c52

Browse files
authored
Merge pull request WebThingsIO#18 from mrstegeman/mdns
Switch mDNS service type to _webthing._tcp.
2 parents 5c05ffb + 08692ed commit 5934c52

File tree

3 files changed

+8
-15
lines changed

3 files changed

+8
-15
lines changed

ESP32WebThingAdapter.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,8 @@ class WebThingAdapter {
3333
Serial.println("MDNS responder started");
3434
}
3535

36-
MDNS.addService("http", "tcp", 80);
37-
MDNS.addServiceTxt("http", "tcp", "url",
38-
"http://" + this->name + ".local");
39-
MDNS.addServiceTxt("http", "tcp", "webthing", "true");
36+
MDNS.addService("webthing", "tcp", 80);
37+
MDNS.addServiceTxt("webthing", "tcp", "path", "/");
4038

4139
DefaultHeaders::Instance().addHeader("Access-Control-Allow-Origin", "*");
4240
DefaultHeaders::Instance().addHeader("Access-Control-Allow-Methods", "PUT, GET, OPTIONS");

ESP8266WebThingAdapter.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,8 @@ class WebThingAdapter {
3131
Serial.println("MDNS responder started");
3232
}
3333

34-
MDNS.addService("http", "tcp", 80);
35-
MDNS.addServiceTxt("http", "tcp", "url",
36-
"http://" + this->name + ".local");
37-
MDNS.addServiceTxt("http", "tcp", "webthing", "true");
34+
MDNS.addService("webthing", "tcp", 80);
35+
MDNS.addServiceTxt("webthing", "tcp", "path", "/");
3836

3937
this->server.on("/", [this]() {
4038
this->handleThings();

WiFi101WebThingAdapter.h

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,15 @@ enum ReadState {
4040
class WebThingAdapter {
4141
public:
4242
WebThingAdapter(String _name): name(_name), server(80), mdns(udp) {
43-
// String url = "url=http://" + name + ".local";
44-
serviceTxt = "\x13webthing=true"; // _" + url;
45-
// serviceTxt[14] = (char)url.length();
4643
}
4744

4845
void begin() {
4946
mdns.begin(WiFi.localIP(), name.c_str());
5047

51-
mdns.addServiceRecord("_http",
48+
mdns.addServiceRecord("_webthing",
5249
80,
53-
MDNSServiceTCP);
54-
// serviceTxt.c_str());
50+
MDNSServiceTCP,
51+
"\x06path=/");
5552

5653
server.begin();
5754
}
@@ -156,7 +153,7 @@ class WebThingAdapter {
156153
}
157154
}
158155
private:
159-
String name, serviceTxt;
156+
String name;
160157
WiFiServer server;
161158
WiFiClient client;
162159
WiFiUDP udp;

0 commit comments

Comments
 (0)