Switch mDNS service type to _webthing._tcp. #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
mrstegeman
commented
Jul 10, 2018
WiFi101WebThingAdapter.h
Outdated
| // String url = "url=http://" + name + ".local"; | ||
| serviceTxt = "\x13webthing=true"; // _" + url; | ||
| // serviceTxt[14] = (char)url.length(); | ||
| serviceTxt = "\x13path=/"; |
There was a problem hiding this comment.
I wasn't sure what the \x13 was for here.
There was a problem hiding this comment.
\x13 is the length of "webthing=true" although it should actually be \x0d (which explains a lot in hindsight).
To add the path the correct incantation is located around here:
https://github.com/arduino-libraries/ArduinoMDNS/blob/master/examples/WiFi/WiFiRegisteringServicesWithTxtRecord/WiFiRegisteringServicesWithTxtRecord.ino#L99
It was removed since the incorrect length \x13 was corrupting the packets
|
@hobinjk Fixed. |
hobinjk
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.