-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub Actions build #105
Fix GitHub Actions build #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
Renaming |
Renaming took GitHub about a minute and has not actually unpublished https://pa11y.org (yet?). Let's see whether the workflow's mention of Update: renaming the default branch triggered its own republish. GitHub's advisories before renamingGitHub's notice once in progressGitHub's notice once complete |
It hasn't, so |
This pull request mainly fixes the build and introduces me to Pa11y PR creation.
make test
step of the GitHub Actions checkcheckout_and_test
which had stopped working recently because of the Ubuntu issue currently affecting pa11y-ci. It does this by regressing the image fromubuntu-latest
toubuntu-20.04
. Soonubuntu-latest
will return.make
.nvmrc
and set to same Node.js version as the CI checkGitHub
andGitHub Issues
If the PR is approved I also plan to rename
master
tomain
a moment before merging it. This is part of verifying this renaming process before extending it to repos which have more consumers, and in this repo's case it will also republish the site, immediately after it is unpublished by the change of name.