Skip to content

Use eslint-config-pa11y for linting #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use eslint-config-pa11y for linting #168

wants to merge 7 commits into from

Conversation

@danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Nov 16, 2025

This PR:

  • Upgrades ESLint to 9 from 8
  • Introduces the new linting package (flat config/shareable config) eslint-config-pa11y
  • Fixes errors and some warnings

@danyalaytekin danyalaytekin added this to the 5.x milestone Nov 16, 2025
@danyalaytekin danyalaytekin self-assigned this Nov 16, 2025
@danyalaytekin danyalaytekin marked this pull request as ready for review November 16, 2025 21:49
sangitamane
sangitamane previously requested changes Nov 18, 2025
View reviewed changes
Copy link
Member

@sangitamane sangitamane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are line length linting errors shown to me, so need to shorten those desc.
Otherwise I am happy to approve.

@danyalaytekin danyalaytekin dismissed sangitamane’s stale review November 18, 2025 19:38

Line-length warnings have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sangitamane sangitamane sangitamane approved these changes

@aarongoldenthal aarongoldenthal Awaiting requested review from aarongoldenthal

@josebolos josebolos Awaiting requested review from josebolos

Assignees

@danyalaytekin danyalaytekin

Labels

type: maintenance

Projects

None yet

Milestone

5.x

Development

Successfully merging this pull request may close these issues.

3 participants

@danyalaytekin @sangitamane