Fix multiple maps not rendering #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tile rendering conflicts - Replaced global `LAYERS` object with a `getLayers()` function to provide fresh instances for each map. - Exported `LAYER_NAMES` for use in plugin options to maintain compatibility with layer selection. - Updated `TrackMapPanel` to use instance-specific layers via `getLayers()` to prevent map rendering conflicts due to shared state. - Modified affected files: `TrackMapPanel.tsx`, `layers.ts`, `module.ts`.
|
Thanks for taking care of this, I'll devote some time to properly review it soon |
pR0Ps
pushed a commit
that referenced
this pull request
Oct 9, 2024
…conflicts (#92) - Replaced global `LAYERS` object with a `getLayers()` function to provide fresh instances for each map. - Exported `LAYER_NAMES` for use in plugin options to maintain compatibility with layer selection. - Updated `TrackMapPanel` to use instance-specific layers via `getLayers()` to prevent map rendering conflicts due to shared state. Fixes #89
|
Merged, thanks for tracking down this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #89
Changes:
Refactor
LAYERS:LAYERSobject with agetLayers()function that returns a new instance of map layers each time it is called.Exported
LAYER_NAMES:PanelPluginoptions to ensure compatibility.LAYER_NAMESarray was introduced to maintain the list of available layer names separately from the actual layer objects.Updated TrackMapPanel:
TrackMapPanel.tsxto use thegetLayers()function, ensuring each map receives its own set of layers, solving the issue of race conditions in tile rendering.Files Modified:
src/TrackMapPanel.tsxsrc/layers.tssrc/module.tsSteps to Reproduce (Before the fix):