Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TIN check, Strict mode and Country check (idea for complementing this library) #14

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ortegafernando
Copy link

Hi, I am not and expert in php, but I have found that you can complement this library with the Europe TIN check service.

It is almost the same as VIES/VAT service.

Porbably, my fork is quite bad and you can improve it a lot, but you may can use this fork for getting some pieces of codes and implement both VAT and TIN checking in one library.

Mine just works, but it is not polite.

@pH-7
Copy link
Owner

pH-7 commented Jun 23, 2024

Thank you so much for your contribution @ortegafernando!! 🎉 I really appreciate this! 😊

Could you add some unit tests (in a new test file). You can have a look at the existing unit tests already written - https://github.com/pH-7/eu-vat-validator/tree/main/tests/Vat

Any other testing or changes, please let me know. Then, I will be happy to merge your contribution to the project 🚀

Enjoy the rest of your weekend.

@ortegafernando
Copy link
Author

Hi, I am a newbie but I have tried to make what you ask me, I have no way to check the test files. I hope you can test and find them ok. Thanks.

@ortegafernando
Copy link
Author

Strict mode added

@ortegafernando
Copy link
Author

Add COUNTRY_NOT_VALID exception to detect when the country is supported or not (both in VAT and TIN)

@ortegafernando ortegafernando changed the title Add TIN check (idea for complementing this library) Add TIN check, Strict mode and Country check (idea for complementing this library) Jun 25, 2024
@ortegafernando
Copy link
Author

Hello, have you got time to see/check this? Thanks.

@ortegafernando
Copy link
Author

Hello, any news? thanks

@pH-7
Copy link
Owner

pH-7 commented Oct 23, 2024

Hi @ortegafernando,

Thank you so much for your patience. I've been quite busy lately. Could you quickly ensure it is also compatible with PHP 8.3 (if you can get it running with it as well as running the unit tests). This would really help me reviewing and merging your PR. Thanks very much for your help

@ortegafernando
Copy link
Author

Hi @pH-7 , please dont worry, we must have patience with your github code because you develop it in your free time, dont worry please.
I have tested it in PHP Version 8.1.29 and in 8.2.4. Is it enough? or do you need 8.3 ?
Please remember that my code is quite simple as I have "duplicate" all your class. I am sure that there is a better way to code this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants