Repository navigation
utils: show error message when priority is missing - #452
Merged
Merged
Conversation
rst0git
force-pushed
the
clean-up
branch
3 times, most recently
from
February 23, 2022 22:00
07e497f to
351c634
Compare
Suggested-by: Antonin Bas <abas@vmware.com> Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
A 'priority' field is required to order entries when the table's match key includes an optional, ternary or range match. Suggested-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu> Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Contributor
|
If you do not mind, I would recommend having separate PRs for things like whitespace cleanup vs. Python import cleanups vs. new features. They are easier to review separately, rather than merged together. |
Member
Author
jafingerhut
reviewed
Feb 24, 2022
| match_types_with_priority = [ | ||
| p4info_pb2.MatchField.TERNARY, | ||
| p4info_pb2.MatchField.RANGE | ||
| ] |
Collaborator
There was a problem hiding this comment.
also optional match_kind, yes?
Collaborator
There was a problem hiding this comment.
I will go ahead and approve this, since this is easy to fix in a later separate PR, one that doesn't have two other open PRs based upon it already :-)
jafingerhut
approved these changes
Feb 24, 2022
jafingerhut
left a comment
jafingerhut
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, and I will open an issue to remind us to add match kind optional handling in a later PR.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a validation for P4Runtime table entries that shows an error message when the
priorityfield is required but not specified. For example: